Skip to content

Add Travis and AppVeyor. #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2018
Merged

Add Travis and AppVeyor. #246

merged 1 commit into from
Feb 10, 2018

Conversation

ehuss
Copy link

@ehuss ehuss commented Feb 3, 2018

Includes changes:

  • Change Clippy to default to run on Rust nightly. We can change this once Clippy is distributed with stable.
  • Various changes to make tests more robust.

Of course you will need to hook up Travis and AppVeyor to the repo. I used defaults for everything except on AppVeyor I used the Visual Studio 2017 environment (instead of 2015).

These run stable/beta/nightly Rust as separate jobs. The syntax tests run in every job.

I'm not an expert on either of these systems, so let me know if you want any changes. Some notes:

  • I left notifications at the default, which just send out an email. Let me know if you would prefer something else, or if you want to add my email to the default notifiers.
  • I didn't add the badges to the Readme. We can add these if you want.
  • We may want to consider setting up the cron/scheduling to force these to run periodically to catch problems with Rust nightly.

I'm still a little concerned about the tests being a little fragile since some of them are testing race conditions, but I've run them a fair number of times and they seem to be doing well for now. Also, it's not unusual for Rust nightly to make minor changes to the diagnostic messages which trip up the tests. Those are pretty easy to fix, though. Nightly is also just broken sometimes.

Includes changes:
- Change Clippy to default to run on Rust nightly.
- Various changes to make tests more robust.
@jasonwilliams
Copy link
Member

@ehuss its up and running i think
https://travis-ci.org/rust-lang/rust-enhanced/builds/339869698

I did my best, first time setting up Travis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants